Repository navigation
feat: a pause before pointerDown delays that finger in device.io.gesture - #553
Draft
vijaysharm wants to merge 1 commit into
Draft
vijaysharm wants to merge 1 commit into
vijaysharm wants to merge 1 commit into
Conversation
Every finger touched down at t=0, so a gesture could tap only once and VoiceOver's double tap (activate), split tap and Magic Tap couldn't be sent. A pause before a finger's pointerDown now becomes that finger's start on the agent, so a second finger can tap after the first lifts. Android's device server still presses every finger at once, so a delayed finger is refused there rather than silently becoming a multi-finger tap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mobile-next/devicekit-ios#110, which adds
startto the agent'sdevice.io.gesture. Draft until that ships andagentVersionIOSis bumped.Summary
device.io.gesturecould tap only once per gesture, because every finger touched down at t=0. With VoiceOver on (#552) that means nothing can be activated: VoiceOver's double tap, split tap and Magic Tap all need a second touch that starts later.A
pausebefore a finger'spointerDownnow delays that finger's touch-down, the W3C meaning of a pause in a pointer's sequence. It is sent to the agent as the finger'sstart. A double tap is a second finger that pauses until the first has lifted;skills/mobilecli/reference.mdhas the example.Risk surface
pointerDown, or after itspointerUp, still extends the previous action, so pinch and drag-and-drop sequences are unchanged.Gestures.replay, which I couldn't test without an Android device.startis omitted from the agent request when unset, so existing gestures send the same JSON as before.Test plan
go test ./... -race(new tests: a pre-down pause becomesstart, a post-up pause still extends the release,startstays out of the JSON when unset, Android refuses a delayed finger)go fmt ./...leaves no diff;golangci-lintv2.13.1 adds no new findingsBehavior verification (real iPhone 13, iOS 27.0.1, with the mobile-next/devicekit-ios#110 agent)
Sent as
device.io.gesturethroughmobilecli server start.77device.io.pinchanddevice.io.swipestill work🤖 Generated with Claude Code