Update toolchain to nightly-2026-09-24 - #4870
Merged
feliperodri merged 2 commits intoSep 29, 2026
Merged
Conversation
`rustc_hir` stopped re-exporting `AttrArgs` at its root (rust-lang/rust#163207, "Update deprecated rustc_hir imports"). The type now lives in `rustc_attr_ir`, which `rustc_hir` re-exports as `attrs`, so the import moves to `rustc_hir::attrs::AttrArgs`. Note this is not `rustc_ast::AttrArgs`, which the compiler helpfully suggests and which is a different type: the AST one carries a full expression, the HIR one carries a lowered literal, and `Attribute::get_normal_item` returns the latter. Resolves model-checking#4866
github-actions
Bot
added
Z-EndToEndBenchCI
feliperodri
enabled auto-merge
September 25, 2026 16:36
tautschnig
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One source change:
rustc_hirstopped re-exportingAttrArgsat its root (rust-lang/rust#163207). The type lives inrustc_attr_ir, whichrustc_hirre-exports asattrs, so the import becomesrustc_hir::attrs::AttrArgs.Worth knowing if you hit this elsewhere: rustc suggests
rustc_ast::AttrArgsinstead, and taking the suggestion compiles the import but then fails on the use site. They are different types — the AST one carries a full expression, the HIR one a lowered literal — andAttribute::get_normal_itemreturns the HIR one.Nothing else in the range touched us. I ran the full set locally on the new toolchain rather than leaning on CI: every compiletest suite (kani, expected, ui, cargo-kani, cargo-ui, script-based-pre, coverage, firecracker, prusti, smack, kani-fixme — 1510 passing, 0 failing), the unit tests for all five crates including
kaniwithconcrete_playback, fmt, clippy with-D warnings, and the LLBC build and its regression suite. The charon patch still applies unchanged.Resolves #4866