fix(vue): space category tree checkbox from its label - #557
Merged
Conversation
PrimeVue Checkbox's box overflows the flex item, so row gap did not show. Put 0.5rem on the label that follows the checkbox.
Vite emits tree styles as a shared chunk. product-tabs.min.css does not include them, so the checkbox gap never reached the Categories tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Во вкладке «Категории» товара подпись стояла вплотную к чекбоксу. У строки уже был
gap: 0.4rem, визуально его съедал бокс PrimeVue Checkbox.Отступ
0.5remнаlabelсразу после чекбокса (+селектор),flex-shrink: 0на чекбоксе. Строки без галочки не сдвигаются. Тот же виджет в дереве опций.Тип изменений
Связанные Issues
Closes #555
Как это было протестировано?
Красный → зелёный:
php tests/ResourceCategoryTreeCheckboxGapTest.phpпадал безmargin-inline-start, после правки exit 0.composer test:smoke,npx eslintна изменённом Vue)Конфигурация тестирования:
Скриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)npx eslintнаResourceCategoryTree.vue)Дополнительные заметки
Refactoring UI: отступ 0.5rem (8px) вместо произвольных 0.4rem. Ревью code-reviewer и thermo-nuclear: блокеров нет. После ревью margin только на
checkbox + label.