Repository navigation
Remove rich.print debug output from search queries - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Removes the two
rich.printcalls inapp/db/queries.pyand theimport richthat only they used:build_conditions: printed each string filter column and its user-supplied values (5 lines per request)get_filtered_data: printed the full SQL of every data queryNo other code in
app/usesrich(git grep -n -w rich -- . ':!uv.lock'finds only thepyproject.tomldependency). That dependency is left in place for now.Verified:
pytestpasses (2 tests).ruff check app/db/queries.pyreports the same 4 errors it does onmain(an unused import and f-strings without placeholders); none are from this change.Note: #20 has the
{query=}line as surrounding context, so merging both may need a small conflict fix.