Skip to content

replaced mmli1 with mmli2 - #218

Open
matthewberry wants to merge 2 commits into
developfrom
mjberry/replace_mmli1_with_mmli2
Open

matthewberry wants to merge 2 commits into
developfrom
mjberry/replace_mmli1_with_mmli2

Conversation

@matthewberry

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Helm chart environment values to move DMM frontend/API hostnames from the mmli1 domain to mmli2 for staging and production, including the production redirect middleware regex.

Changes:

  • Update staging ingress hostname to dmm.frontend.staging.mmli2.ncsa.illinois.edu
  • Update staging API base hostname to https://dmm.fastapi.staging.mmli2.ncsa.illinois.edu
  • Update production extra host, API base hostname, and redirect regex to mmli2

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
chart/values.staging.yaml Switches staging ingress + API hostname from mmli1 to mmli2.
chart/values.prod.yaml Switches production extra host + API hostname to mmli2 and updates redirect regex accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bodom0015 bodom0015 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewberry happy to approve these, but just a heads-up that I don't think these particular values files do anything anymore

During the migration I created new files for mmli2 to keep their config separate and allow us to rollback if needed (but this separation is no longer necessary):

@matthewberry

Copy link
Copy Markdown
Contributor Author

Oh, sorry I missed those, @bodom0015 !

Let me take a closer look at the issue I was seeing last week--I thought the frontend was trying to call the backend using an mmli1 URL, but I might've gotten that wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants