Repository navigation
tantivy: backfill today's converged files - #431
Merged
Merged
Conversation
The backfill skipped today's partition to avoid racing the hot-tail packer, but the packer never repacks a file at its target size. Such a file whose coverage is only carried-forward entries (up to 539 on prod) was searched as hundreds of indexes until the date rolled over; it is now rebuilt as one.
|
Review: looks good, small and well-scoped.
I haven't run the build or tests. LGTM, pending the threshold check above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #427 a warm 7-day errors list on 6297304f still searched ~291 indexes per query, most of them carried-forward entries on today's packed files (up to 539 covering one file). The census already counts such a file as uncovered (carried entries surrender ordinals), but the backfill dropped all of today's partition to avoid racing the hot-tail packer — and the packer never repacks a file at its target size.
drop_hot_partitionnow keeps today's files at or abovetimefusion_light_optimize_target_size, so the backfill rebuilds them as one index within its existing per-pass file/byte budget. Smaller (still-packing) files of today stay skipped.Test: the hot-partition case table gains a converged file; red when the predicate is ignored.
Local signoff:
make ci-signofffmt/test/pg-smoke/e2e/clippy all pass (attested).🤖 Generated with Claude Code