Repository navigation
tantivy: rebuild a rewrite's index past 2 carried entries, not 8 - #432
Merged
Merged
Conversation
Today's partition stays below the packing target, so the backfill never consolidates it, and at a cap of 8 the 33 live files of one project were searched as 260 indexes (~2.8 s of a 3.8 s warm 7-day list). Hot-tail outputs are small, so rebuilding them is cheap.
Monoscope production impact · Worth checkingProject Evidence window (UTC): 2026-10-18 18:37:20.411825172 UTC → 2026-10-25 18:37:20.411825172 UTC
Production details are available in Monoscope. Coverage: Open Monoscope for evidence and coverage details. |
|
Review: small, focused change (const 8 → 2 plus a matching test update). Looks good to me.
No blocking issues. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #427/#430. Today's partition for 6297304f is 33 live files, all far below the 128 MiB packing target, so the converged-file backfill (#430) never applies; at a carry cap of 8 those 33 files carried 260 index entries (none stale), and a warm 7-day errors list spends ~2.8 s of its 3.8 s searching them.
MAX_CARRIED_ENTRIES8 → 2. Hot-tail wave outputs are small, so the extra rebuilds are cheap (~1 core estimated at ~2.4 waves/min against 48 cores, 2-7 in use).Test:
carry_forward_declines_past_the_carried_entry_capnow 3 inputs decline / 2 carry; red with the cap at 3.Local signoff:
make ci-signofffmt/test/pg-smoke/e2e/clippy all pass (attested).🤖 Generated with Claude Code