Skip to content

[repo] Address issues with dark mode (fixes #1384) - #1402

Merged
andrewnicols merged 1 commit into
moodle:mainfrom
andrewnicols:darkmode
Jul 16, 2025
Merged

[repo] Address issues with dark mode (fixes #1384)#1402
andrewnicols merged 1 commit into
moodle:mainfrom
andrewnicols:darkmode

Conversation

@andrewnicols

Copy link
Copy Markdown
Member

No description provided.

@andrewnicols andrewnicols self-assigned this Jul 14, 2025
Copilot AI review requested due to automatic review settings July 14, 2025 03:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses dark mode styling by introducing a custom background color variable.

  • Adds a new CSS variable for the dark mode background color.
Comments suppressed due to low confidence (2)

src/css/custom.css:48

  • [nitpick] Consider adding a comment above this line to explain the choice of #1b1b1d and how it integrates with the overall dark theme palette.
  --ifm-background-color: #1b1b1d;

src/css/custom.css:48

  • It would be helpful to add a visual regression test or CSS snapshot test to verify that the background color is applied correctly in dark mode.
  --ifm-background-color: #1b1b1d;

@netlify

netlify Bot commented Jul 14, 2025

Copy link
Copy Markdown

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 7e01c37
🔍 Latest deploy log https://app.netlify.com/projects/moodledevdocs/deploys/687479ce6d380b0008c6f23b
😎 Deploy Preview https://deploy-preview-1402--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@HuongNV13

Copy link
Copy Markdown
Member

Thanks, Andrew!
The changes look right to me!

@andrewnicols
andrewnicols added this pull request to the merge queue Jul 16, 2025
Merged via the queue into moodle:main with commit 225d850 Jul 16, 2025
7 checks passed
@andrewnicols
andrewnicols deleted the darkmode branch July 16, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants