[public allocator] docs: forceDeallocatePenalty - #965
Closed
MathisGD wants to merge 2 commits into
Closed
Conversation
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
peyha
reviewed
Aug 11, 2026
| /// @dev The vault's allocators can manage the public allocators' settings. | ||
| /// @dev Each reallocate and allocateFromIdle call costs a penalty in native currency, set per vault by the allocators. | ||
| /// The penalty is accrued per vault and can be claimed by the vault's allocators. | ||
| /// @dev The vault's forceDeallocatePenalty is ignored by this contract. |
Contributor
There was a problem hiding this comment.
feel like this comment is not so clear
we could be more explicit with something like
Suggested change
| /// @dev The vault's forceDeallocatePenalty is ignored by this contract. | |
| /// @dev If the vault's forceDeallocatePenalty is high while the public allocator's penalty is low, it could be cheaper to deallocate via the public allocator |
Collaborator
Author
There was a problem hiding this comment.
I don't want to list all the specific scenarios but instead just point at the fact that this is ignored => it invalidates a bunch of issues and makes people think about what they need to care about wrt penalties. wdyt?
Contributor
There was a problem hiding this comment.
I don't think we should specify scenarios neither but the current version looks very blurry, I'm not sure people will grasp the implication on forcedeallocate
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cantina.xyz/code/b6e917be-dc53-4f66-b58e-406e4d1be2fe/findings/15