Repository navigation
[esignet-2667] Allow Keycloak init YAML to configure audience mappers - #2740
Draft
Ivanmeneges wants to merge 5 commits into
Draft
Ivanmeneges wants to merge 5 commits into
Ivanmeneges wants to merge 5 commits into
Conversation
Mapper entries still default to oidc-usermodel-attribute-mapper. An entry can set protocol_mapper to oidc-audience-mapper and supply included_client_audience or included_custom_audience so that value is added to the access token aud claim. The published keycloak-init chart install path is unchanged. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
The checks were only used while verifying the audience mapper. The init script change does not depend on them. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
The README no longer points this script change at mosip/keycloak. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
AGENTS.md points mapper changes at mosip/keycloak. The eSignet values file shows the audience mapper shape without adding it to any client. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
…n re-run. A 409 leaves included_client_audience unchanged until that mapper is deleted and init runs again. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2667.
Documents the optional audience mapper in
AGENTS.mdanddeploy/keycloak/keycloak-init-values.yaml. No client is given an audience mapper. Existingmapperslists stay as they are.The script change itself belongs in mosip/keycloak#216. A mapper entry without
protocol_mapperstaysoidc-usermodel-attribute-mapper.protocol_mapper: oidc-audience-mapperwithincluded_client_audienceorincluded_custom_audienceadds that value to the access tokenaud.