Skip to content

Fixes mosip/esignet #2667 Refactor mapper creation logic - #217

Merged
ckm007 merged 7 commits into
developfrom
Ivanmeneges-patch-3
Oct 26, 2026
Merged

ckm007 merged 7 commits into
developfrom
Ivanmeneges-patch-3

Conversation

@Ivanmeneges

Copy link
Copy Markdown

Updated Keycloak image repository and tag, modified security context comments, and adjusted ingress annotations. Cleaned up resource comments and streamlined attributes for various clients.

Updated Keycloak image repository and tag, modified security context comments, and adjusted ingress annotations. Cleaned up resource comments and streamlined attributes for various clients.

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 25f25848-2f48-494c-8fbc-8028400a8fb9
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Refactor mapper creation logic to use a dedicated mapper_payload function for building the Keycloak protocol-mapper body. Added validation for configured mappers to ensure correct mapper configurations before realm or client creation.

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Added detailed explanation of protocol mappers and their configuration in Keycloak. Included YAML examples for mapper entries and clarified behavior for existing mappers.

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Updated AGENTS.md to reflect changes in Keycloak init mappers and added guidance for coding agents. Revised sections on purpose, layout, and agent rules.

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Expanded the AGENTS.md documentation to include detailed information about the purpose, layout, structure, configuration, and agent rules for the keycloak-init project.

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Enhanced secret retrieval logic and improved error handling for service account client roles assignment.

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
@ckm007
ckm007 merged commit a7330a3 into develop Oct 26, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants