Repository navigation
[MOSIP-45612] Load recommended centers from the configured address - #261
Closed
mohanachandran-s wants to merge 1 commit into
Closed
mohanachandran-s wants to merge 1 commit into
mohanachandran-s wants to merge 1 commit into
Conversation
The recommended centers were loaded from the last location field in the UI spec at the recommended hierarchy level, so with more than one address (permanent and present) the result depended on the order of the fields. Add preregistration.recommended.centers.locationField to choose the UI spec field (ex: presentZipcode) used for recommended centers. When it is not set or is not a location field at that level, the last matching field is used, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
MOSIP-45612: the nearest/recommended registration centre was picked from the last address field in the UI spec at the
preregistration.recommended.centers.locCodehierarchy level. With more than one address (permanent and present), the result depended on field order, not on a chosen address type.Change
preregistration.recommended.centers.locationField: the UI spec field id to use, e.g.presentZipcodefor the current address.CenterSelectionComponent.getRecommendedCenterLocationField()uses the configured field when it is a location field at the recommended hierarchy level.Depends on
Backend exposes the key to the UI via
ui.config.params: mosip/pre-registration#1090. Deployments must also add the key topre-registration-default.propertiesin mosip-config, including inui.config.params.Testing
tsc --noEmitpasses for the app and spec configs.🤖 Generated with Claude Code