Repository navigation
fix(telemetry): read plain-text token counters from the usage summary - #293
Merged
Merged
Conversation
The fallback parser for custom reviewer commands took the first match of each counter, so numbers quoted in the review text beat the real summary printed after it. It also added cached tokens on top of input when it derived a total, though cached tokens are part of input, and its input pattern matched "cached input tokens" lines. The last match now wins, "cached input" is not read as input, and a derived total is input plus output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ajay Singh · project thread
What changed
cached input tokens:lines.cached inputisn't read as input.Verification
tests/test_plain_text_token_usage.pydrives the realparse_agent_outputfallback.test_ui_exportfailures, which also fail on main.ruff check,ruff format --checkandcz checkpass.Notes
Generated by Claude Code