Repository navigation
Conversation
If a tag points to a commit that isn't on a branch synced to the destination repository, it can't get Mercurial metadata, and the whole message would fail and be requeued forever, blocking the queue. Log an error and report to Sentry instead, pointing to the manual tag push documentation, and carry on with the rest of the message. Also don't attempt to add metadata with a dry-run push when there are no branches to push (the push would then fail with a confusing "nothing changed on remote" error), and only do it once per sync, so the rollback candidate isn't overwritten after metadata was already forced.
jcristau
force-pushed
the
skip-unsynced-tags
branch
from
October 15, 2026 08:28
ddd5595 to
aa34de1
Compare
jcristau
changed the title
jcristau
marked this pull request as ready for review
October 15, 2026 08:30
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
shtrom
reviewed
Oct 21, 2026
| ): | ||
| raise MercurialMetadataNotFoundError(tag_operation) | ||
| exc = MercurialMetadataNotFoundError(tag_operation, destination_url) | ||
| sentry_sdk.capture_exception(exc) |
Member
There was a problem hiding this comment.
Could you rebase this on #174, and re-add the import sentry_sdk in this file?
Member
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a tag points to a commit that isn't on a branch synced to the destination repository, it can't get Mercurial metadata, and the whole message would fail and be requeued forever, blocking the queue. Log an error and report to Sentry instead, pointing to the manual tag push documentation, and carry on with the rest of the message.
Also don't attempt to add metadata with a dry-run push when there are no branches to push (the push would then fail with a confusing "nothing changed on remote" error), and only do it once per sync, so the rollback candidate isn't overwritten after metadata was already forced.