Repository navigation
config: simplify SentryConfig env override (bug 2058322) - #175
Merged
Merged
Conversation
Member
Author
|
Tested successfully in dev https://mozilla.sentry.io/issues/7803593757/?project=4509195219369984&referrer=project-issue-stream |
cgsheeh
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used an
AliasChoicesto avoid double-prefixing theSENTRY_DSNenvironment variable. This had the unexpected side-effect that the variable would not override values explicitly provided from the configuration file, even if just empty strings, asSENTRY_SENTRY_DSNwould.We just simplify the logic by renaming the
sentry_dsnattribute in thesentrysub-config to justdsn. This now directly maps to the desiredSENTRY_DSN, and behaves as expected.