Skip to content

Bug 2078184 - Add author's GitHub login to the github_prod_metrics table - #21

Merged
dklawren merged 1 commit into
mainfrom
2078184
Oct 6, 2026
Merged

dklawren merged 1 commit into
mainfrom
2078184

Conversation

@dklawren

@dklawren dklawren commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@dklawren
dklawren requested review from cgsheeh and shtrom and a balanced review from Copilot October 5, 2026 20:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A production BigQuery schema migration is needed before the new field can be loaded safely.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Adds pull request authors’ GitHub logins to BigQuery metrics.

Changes:

  • Extracts user.login during transformation.
  • Extends the local schema and carry-forward columns.
  • Tests present, absent, and null users.
File Description
main.py Transforms and carries forward author usernames.
data.yml Adds the field to the emulator schema.
tests/​test_transform_data.py Tests author extraction and missing users.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread data.yml
@dklawren
dklawren merged commit 53b05bb into main Oct 6, 2026
4 of 6 checks passed
@dklawren
dklawren deleted the 2078184 branch October 6, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants