Bug 2062223 - #2758
Merged
Merged
Bug 2062223#2758
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The authorization fix is consistently applied and covered by focused regression scenarios.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents unauthorized security-group removal during product moves while preserving valid automatic cleanup behavior.
Changes:
- Requires group membership to remove valid restrictions.
- Locks protected group controls in both interfaces.
- Adds regression coverage for single- and multi-bug moves.
| File | Description |
|---|---|
Bugzilla/Bug.pm |
Enforces removal authorization and computes multi-bug group status. |
template/en/default/bug/process/verify-new-product.html.tmpl |
Preserves and locks existing restrictions during moves. |
extensions/BugModal/lib/WebService.pm |
Supplies lock state for BugModal group controls. |
extensions/BugModal/template/en/default/bug_modal/new_product_groups.html.tmpl |
Disables protected group checkboxes. |
t/bmo/security-group-declass-via-product-move.t |
Tests declassification prevention and supported move behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2062223