Bug 2055580 - #2759
Merged
Merged
Bug 2055580#2759
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the visibility-query inefficiency, missing legacy-secret tests, and dependency-manifest mismatch before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Hardens GitHub webhook authorization by scoping actions to the signing bot’s visibility and improving attribution.
Changes:
- Adds visibility checks, identity logging, and disabled-account handling.
- Expands webhook security and attribution tests.
- Updates documentation, dependency metadata, and Dockerfile formatting.
| File | Description |
|---|---|
template/en/default/admin/params/github.html.tmpl |
Updates administrator guidance. |
t/github-webhook-bug-visibility.t |
Adds webhook visibility security tests. |
qa/t/rest_github_push_comment.t |
Verifies push-comment attribution. |
qa/t/rest_github_pull_request.t |
Verifies pull-request attribution. |
Makefile.PL |
Removes Net::CIDR, but generated dependency manifests remain inconsistent. |
docs/en/rst/api/core/v1/github.rst |
Documents security boundaries; legacy shared-secret attribution needs clarification. |
Dockerfile |
Removes extraneous whitespace. |
Bugzilla/API/V1/Github.pm |
Implements visibility and identity checks; visibility queries need batching and legacy-secret security coverage is missing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…o avoid N+1 queries' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2055580