Skip to content

Fix Phabricator URL action references#6334

Open
ShreyanshGoyal wants to merge 1 commit into
mozilla:masterfrom
ShreyanshGoyal:6330-phabricator-reference-url
Open

Fix Phabricator URL action references#6334
ShreyanshGoyal wants to merge 1 commit into
mozilla:masterfrom
ShreyanshGoyal:6330-phabricator-reference-url

Conversation

@ShreyanshGoyal

@ShreyanshGoyal ShreyanshGoyal commented Jul 18, 2026

Copy link
Copy Markdown

Summary

  • expose the canonical url field in successful Phabricator submission results
  • retain revision_url for compatibility with existing consumers
  • cover the documented action-reference contract in the handler test

Rationale

The phabricator.submit_patch action tells agents to reference a submitted revision with {{actions.<ref>.url}}. The apply handler returned only revision_url, so the placeholder resolver could not find url and left the literal reference in Bugzilla comments. Returning the documented alias makes those references resolvable without breaking consumers of revision_url.

Fixes #6330.

Test plan

  • Confirmed the updated handler assertion fails before the source change
  • python -m pytest libs/hackbot-runtime/tests/test_phabricator_handler.py libs/hackbot-runtime/tests/test_phabricator_actions.py -q (18 passed)
  • python -m ruff check and python -m ruff format --check on the changed Python files
  • python -m compileall -q libs/hackbot-runtime/hackbot_runtime/actions/handlers/phabricator_handler.py

The action schema tells agents to use {{actions.<ref>.url}}, but the apply handler only returned revision_url. Preserve that field and add the documented url alias so Bugzilla comments can resolve patch links.
@ShreyanshGoyal
ShreyanshGoyal requested a review from a team as a code owner July 18, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hackbot does not substitute action references when commenting on Bugzilla.

1 participant