Fix Phabricator URL action references#6334
Open
ShreyanshGoyal wants to merge 1 commit into
Open
Conversation
The action schema tells agents to use {{actions.<ref>.url}}, but the apply handler only returned revision_url. Preserve that field and add the documented url alias so Bugzilla comments can resolve patch links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlfield in successful Phabricator submission resultsrevision_urlfor compatibility with existing consumersRationale
The
phabricator.submit_patchaction tells agents to reference a submitted revision with{{actions.<ref>.url}}. The apply handler returned onlyrevision_url, so the placeholder resolver could not findurland left the literal reference in Bugzilla comments. Returning the documented alias makes those references resolvable without breaking consumers ofrevision_url.Fixes #6330.
Test plan
python -m pytest libs/hackbot-runtime/tests/test_phabricator_handler.py libs/hackbot-runtime/tests/test_phabricator_actions.py -q(18 passed)python -m ruff checkandpython -m ruff format --checkon the changed Python filespython -m compileall -q libs/hackbot-runtime/hackbot_runtime/actions/handlers/phabricator_handler.py