gecko: Prevent ZSTs with ThinVec when in gecko-ffi mode. - #94
Merged
Merged
Conversation
emilio
force-pushed
the
zst-landmines
branch
from
September 15, 2026 17:37
dae1115 to
0d872fd
Compare
This prevents bugs like https://bugzilla.mozilla.org/show_bug.cgi?id=2067654 Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=2072302 While it's possible to make this a compile-time panic rather than a runtime panic, doing so is a breaking change, and makes testing a PITA, since the only feature that I can think of that allows to test that something shouldn't compile are doctests, and doctests don't work with the gecko-ffi mode :/
emilio
force-pushed
the
zst-landmines
branch
from
September 15, 2026 17:48
c39ca79 to
0d9613e
Compare
emilio
force-pushed
the
zst-landmines
branch
from
September 15, 2026 21:41
0d9613e to
c2776d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents bugs like
https://bugzilla.mozilla.org/show_bug.cgi?id=2067654
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=2072302