Skip to content

ci/mac: don't apply werror to the linker for the oldest target #18410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feldgendler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci/mac: don't apply werror to the linker for the oldest target #18410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ci/build-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,25 @@ set -e
MPV_INSTALL_PREFIX="${HOME}/out/mpv"
MPV_VARIANT="${TRAVIS_OS_NAME}"

objc_args="-Wno-error=deprecated -Wno-error=deprecated-declarations"

# Homebrew's libraries are built for the macOS version of the runner, so ld
# warns for each of them when building for an older deployment target. meson
# 1.12 passes -Wl,-fatal_warnings with werror, so only apply werror to the
# compilers.
if [[ -n "${MACOSX_DEPLOYMENT_TARGET}" ]]; then
common_args="${common_args/--werror/-Dwerror=false -Dc_args=-Werror}"
objc_args="-Werror ${objc_args}"
fi

if [[ -d "./build/${MPV_VARIANT}" ]] ; then
rm -rf "./build/${MPV_VARIANT}"
fi

PKG_CONFIG_PATH="$(brew --prefix libarchive)/lib/pkgconfig/" CC="${CC}" CXX="${CXX}" \
meson setup build $common_args \
-Dprefix="${MPV_INSTALL_PREFIX}" \
-Dobjc_args="-Wno-error=deprecated -Wno-error=deprecated-declarations" \
-Dobjc_args="${objc_args}" \
-D{caca,cdda,dvdnav,gl,iconv,lcms2,libarchive,libbluray,lua,jpeg}=enabled \
-D{plain-gl,rubberband,zimg,zlib}=enabled \
-D{cocoa,coreaudio,gl-cocoa,videotoolbox-gl,videotoolbox-pl}=enabled \
Expand Down
Loading