Repository navigation
Fix startup crash in non-ASCII install folders; pin engine to main - #130
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a 2.2.10 startup crash for players whose install folder has a non-ASCII name, and moves the engine pin back to snesrecomp
main.The crash. A player's game aborted 123 ms after start, before the launcher opened. Their install folder was
C:\Users\…\Desktop\Emuladores\Mega Man X Recompilé\. I reproduced it with 2.2.10 in an accented folder:std::filesystemthrewCannot convert character sequence: Illegal byte sequencewhile the mod runtime openedmods/preloaded, and the exception reachedstd::terminate. The C host passes paths in the ANSI code page, butstd::filesystemand the launcher pickers treat them as UTF-8.The pin. Since the Boss Rush integration (39d84b9), MMX pinned snesrecomp
fix/appimage-keybind-path, a branch carrying three fixes that were never PR'd: interpreter hook capacity, mod audio voices across rollback, and AppImage keybinds. RetroPortingToolKit/snesrecomp#188 upstreamed them, so MMX now pinsmain(7a67b85) and recomp-uimaster(7c635c6). Main also brings 12 earlier engine commits, including generator changes, so the code was regenerated.Version: 2.2.11.
Validated on Windows (MinGW):
Mega Man X Recompilé 2\: it boots, the mod runtime writesstate.toml, and the launcher shows "ROM verified". The 2.2.10 build aborts in the same folder.🤖 Generated with Claude Code