Skip to content

Fix startup crash in non-ASCII install folders; pin engine to main - #130

Merged
mstan merged 1 commit into
mainfrom
fix/engine-main-utf8-paths
Oct 20, 2026
Merged

mstan merged 1 commit into
mainfrom
fix/engine-main-utf8-paths

Conversation

@mstan

@mstan mstan commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Fixes a 2.2.10 startup crash for players whose install folder has a non-ASCII name, and moves the engine pin back to snesrecomp main.

The crash. A player's game aborted 123 ms after start, before the launcher opened. Their install folder was C:\Users\…\Desktop\Emuladores\Mega Man X Recompilé\. I reproduced it with 2.2.10 in an accented folder: std::filesystem threw Cannot convert character sequence: Illegal byte sequence while the mod runtime opened mods/preloaded, and the exception reached std::terminate. The C host passes paths in the ANSI code page, but std::filesystem and the launcher pickers treat them as UTF-8.

The pin. Since the Boss Rush integration (39d84b9), MMX pinned snesrecomp fix/appimage-keybind-path, a branch carrying three fixes that were never PR'd: interpreter hook capacity, mod audio voices across rollback, and AppImage keybinds. RetroPortingToolKit/snesrecomp#188 upstreamed them, so MMX now pins main (7a67b85) and recomp-ui master (7c635c6). Main also brings 12 earlier engine commits, including generator changes, so the code was regenerated.

Version: 2.2.11.

Validated on Windows (MinGW):

  • Regenerated from the ROM; the build is clean and CTest passes 22/22 (2 optional Saber tests skipped, as before).
  • An 18,000-frame soak ran clean.
  • The packaged build runs from Mega Man X Recompilé 2\: it boots, the mod runtime writes state.toml, and the launcher shows "ROM verified". The 2.2.10 build aborts in the same folder.
  • The executable carries the UTF-8 manifest.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mstan
mstan merged commit ada005c into main Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant