Repository navigation
Protect Boss Rush bosses from Gravity Well during entrances - #131
Merged
Merged
Conversation
mstan
marked this pull request as ready for review
October 20, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An active Gravity Well could capture Boss Rush bosses while their entrances used ordinary-enemy state and damage-category bytes, then dissolve or lift them into a false defeat. Check the Rush boss body's identity from allocation onward when selecting victims, validating retained captures, and supplying their renderer/AI override. Older snapshots containing an illegal boss capture release it safely. Ordinary minions sharing a boss's ownership tag remain eligible.
Adds a ROM-backed regression for normal/charged fields across all eight bosses in both seats, illegal-capture save/load, and deterministic entrance replay. Also adds an X3 Zero saber timing probe for campaign/Boss Rush and solo/local co-op: idle, repeated swings, real boss hits, and the full charge/two-buster/saber input chain, comparing diagnostics off/on after warming caches. The reported saber slowdown was not reproduced in these probes; this PR makes no speculative saber behavior change.
Validated on current main with its exact engine/UI/library pins:
Mean CPU time per game update plus compositor draw during the full X3 combo (768 frames per logging mode, warmed caches; this shared Windows host):
Some individual frames spike with either logging setting. The affected user's replay and setup are still needed to identify their slowdown.
Tracking:
beads-8wg.1.136.