Skip to content

fix(codex): once-per-turn outcome review through the Stop hook (main) - #59

Open
e1daru wants to merge 14 commits into
mainfrom
feat/codex-24-review-main
Open

e1daru wants to merge 14 commits into
mainfrom
feat/codex-24-review-main

Conversation

@e1daru

@e1daru e1daru commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Published counterpart of #42, already merged into pre-main. Installed plugins run what is on main, so this is how that change reaches users.

The review on Codex, and Stop fixes shared by both hosts:

  • any later Stop of a reviewed turn is its follow-up, so the review never repeats and one outcome is sent;
  • use is measured on the first answer only, since the review lists the lesson titles;
  • a reply to a message typed after the review is stored as its own item.

main carries no sources or tests. Every file here matches pre-main at the merge of #42, with two differences: bundles lose their inline sourcemap line, and paths that don't ship (sources, tests, labs/, verify.yml) are left out. Applied to pre-main before this series, that rule reproduces today's main byte for byte.

Merge order

14 of 16. Merge after #58. This PR targets main directly, so until #58 merges its diff also shows the earlier PRs in the series.

Test plan

  • Sources: fix(codex): once-per-turn outcome review through the Stop hook #42's CI on pre-main. At the pre-main tip: Claude Code 2341 on source and dist, Codex 635 on both, manifests, bundles match their source.
  • This tip: every shipped script passes node --check, and none carries an inline sourcemap.
  • Both hosts, offline in a throwaway home: session-start and capture --stop exit 0 with valid output, and both MCP servers answer initialize and tools/list (mubit-memory@0.13.2, 7 tools).
  • leakcheck --strict exit 0.

🤖 Generated with Claude Code

e1daru and others added 14 commits September 29, 2026 13:33
…(main)

Published form of #26: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…enderer (main)

Published form of #27: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… credit (main)

Published form of #28: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w text (main)

Published form of #29: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ain)

Published form of #30: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ard (main)

Published form of #31: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published form of #32: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published form of #33: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published form of #34: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published form of #36: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…main)

Published form of #38: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published form of #39: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on log (main)

Published form of #41: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Published form of #42: the rebuilt bundles without their inline
sourcemap line, and the docs, skills and manifests that ship. Sources
and tests stay on pre-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants