Repository navigation
fix: use 64-bit seek/tell that MSVC has in the bundle loader - #97
Merged
Merged
Conversation
fseeko and ftello are POSIX only, so the Windows cpu, cuda and vulkan builds of v0.6.0 failed with C3861 in model_loader.cpp and the release job was skipped. Wrap them in two small helpers that call _fseeki64 and _ftelli64 on Windows and keep fseeko/ftello elsewhere. Assisted-by: Claude:claude-sonnet-5-5 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.0 release run failed on the Windows cpu, cuda and vulkan builds, which skipped the release job:
fseekoandftelloare POSIX only. They came in with the bundle loader (#85). This wraps them in two small helpers that call_fseeki64and_ftelli64on Windows and keepfseeko/ftelloelsewhere.Checked:
model_loader.cppcompiles on Linux. Not built on Windows locally, so the Windows CI jobs are the real test.Failed run: https://github.com/mudler/parakeet.cpp/actions/runs/37343894038
🤖 Generated with Claude Code