Skip to content

Fix issue with transfer value event - #142

Open
miiu96 wants to merge 1 commit into
mainfrom
sc-call-with-transfer-value-issue
Open

miiu96 wants to merge 1 commit into
mainfrom
sc-call-with-transfer-value-issue

Conversation

@miiu96

@miiu96 miiu96 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Context

A transaction with value that deploys a child contract via DeployFromSource emits a transferValueOnly event with data = "DeployFromSource". Previously decideEffectiveEventTransferValueOnly only considered ExecuteOnDestContext / AsyncCall / TransferAndExecute as effective, so the event was ignored and the value-transfer to the newly deployed contract was not represented in Rosetta operations.

Fix

Update decideEffectiveEventTransferValueOnly() to accept DeployFromSource as effective.

@miiu96 miiu96 self-assigned this Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.33%. Comparing base (82db28d) to head (ff9382e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   57.84%   58.33%   +0.48%     
==========================================
  Files          48       48              
  Lines        3115     3118       +3     
==========================================
+ Hits         1802     1819      +17     
+ Misses       1169     1157      -12     
+ Partials      144      142       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants