Skip to content

fix(sdk): issue-880 avoid hard-coding to template - #887

Merged
michaeltangpub2 merged 6 commits into
mainfrom
michaeltang/fix/issue-885
Mar 4, 2026
Merged

fix(sdk): issue-880 avoid hard-coding to template#887
michaeltangpub2 merged 6 commits into
mainfrom
michaeltang/fix/issue-885

Conversation

@michaeltangpub2

@michaeltangpub2 michaeltangpub2 commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Currently the request/response body passed as variables from java to template is hard-coded like:

coordinatedAction": "${mefRequestBody.productOrderItem[0].coordinatedAction}",

Enhance to make variable name configurable via kraken/kraken-app/kraken-app-hub/src/main/resources/application.yaml:

app:
    runnerContext:
      queryParamsName: "tmfQuery"
      requestBodyName: "tmfRequestBody"
      responseBodyName: "tmfResponseBody"

Then refer the customized variable name as

coordinatedAction": "${tmfRequestBody.productOrderItem[0].coordinatedAction}",

Related Issue

#885

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Self Checklist

  • I ensured that I are not pushing configuration files containing sensitive information such as testing keys.
  • I ensured that large PR is avoided, Consider splitting if there are more than 500 line changes, In addition to line count, also consider the number of files being affected, An ideal amount is less than 10, 25-30 is generally too large with the exception of library upgrades, refactors, etc.
  • I ensured that If the PR is inevitably large, a short PR review meeting or discuss with reviewers will be organized.
  • I ensured that If the PR is to resolve a blocker, do not make unrelated changes in the same PR e.g. formatting changes, to minimize review time.
  • I ensured that PR is focused
  • I ensured that context was given in the PR description, Include a clear description of the changes
  • I ensured that related github issues are linked, Include screenshots if this will make the context clearer for the reviewer
  • I ensured that "work in progress" or "hold" labels are removed
  • I ensured that adherence to style guidelines
  • I ensured that feature flag is applied if needed
  • I ensured that follow secure development practices
  • I ensured that no secrets or sensitive data have been committed or logged
  • I ensured that no hardcoded values that may change depending on environment (these should be configured dynamically e.g. through environment variables, from the db etc)

@michaeltangpub2
michaeltangpub2 requested a review from a team as a code owner March 3, 2026 15:24
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
ajv 8.17.1 Medium 8.18.0 GHSA-2g4f-4pwh-qvx6
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
commons-lang3 3.17.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
lodash 4.17.21 Medium 4.17.23 GHSA-xxjr-mmjv-4gpg
qs 6.14.1 Low 6.14.2 GHSA-w7fw-mjwx-w883
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
ajv 8.17.1 Medium 8.18.0 GHSA-2g4f-4pwh-qvx6
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
commons-lang3 3.17.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
lodash 4.17.21 Medium 4.17.23 GHSA-xxjr-mmjv-4gpg
qs 6.14.1 Low 6.14.2 GHSA-w7fw-mjwx-w883
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
ajv 8.17.1 Medium 8.18.0 GHSA-2g4f-4pwh-qvx6
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
commons-lang3 3.17.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
lodash 4.17.21 Medium 4.17.23 GHSA-xxjr-mmjv-4gpg
qs 6.14.1 Low 6.14.2 GHSA-w7fw-mjwx-w883
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
ajv 8.17.1 Medium 8.18.0 GHSA-2g4f-4pwh-qvx6
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
commons-lang3 3.17.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
lodash 4.17.21 Medium 4.17.23 GHSA-xxjr-mmjv-4gpg
qs 6.14.1 Low 6.14.2 GHSA-w7fw-mjwx-w883
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

1 similar comment
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
ajv 8.17.1 Medium 8.18.0 GHSA-2g4f-4pwh-qvx6
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
commons-lang3 3.17.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
lodash 4.17.21 Medium 4.17.23 GHSA-xxjr-mmjv-4gpg
qs 6.14.1 Low 6.14.2 GHSA-w7fw-mjwx-w883
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
ajv 8.17.1 Medium 8.18.0 GHSA-2g4f-4pwh-qvx6
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
commons-lang3 3.17.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
lodash 4.17.21 Medium 4.17.23 GHSA-xxjr-mmjv-4gpg
qs 6.14.1 Low 6.14.2 GHSA-w7fw-mjwx-w883
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'kraken_nodejs'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'kraken_java'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

xuelianhan007
xuelianhan007 approved these changes Mar 4, 2026
View reviewed changes

@xuelianhan007 xuelianhan007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@michaeltangpub2
michaeltangpub2 merged commit a1cc4d9 into main Mar 4, 2026
7 checks passed
@michaeltangpub2
michaeltangpub2 deleted the michaeltang/fix/issue-885 branch March 4, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiyaoPCCW zhiyaoPCCW zhiyaoPCCW approved these changes
@xuelianhan007 xuelianhan007 xuelianhan007 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaeltangpub2 @zhiyaoPCCW @xuelianhan007