Repository navigation
PDF: own textpages and streamline geometry materialization - #27
Merged
myhloli merged 2 commits intoSep 29, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
myhloli
merged commit Sep 29, 2026
0552b0c
into
codex/rust-pdf-stage19-visual-evidence
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto|python|rustcompute andauto|legacy|sessionrender selection.NativeTextSnapshot.geometry()materialization overhead by indexing shared font dictionaries, caching field names, constructing bbox inputs directly, and sharing origin/loose/tight coordinate objects without changing public geometry shape or mutability semantics.docs/rust-pdf-stage20-evidence.md.Correctness
-D warnings, rustfmt, Ruff check, and changed-file formatting passed.77c16ff6c926daea4b8ec631f192ba0f3593791cd885391cbe13d4cdf6d862d8. DocVortex core and MinerU Flash smoke outputs matched forautoandrust.Measured performance
One warmup plus five hot runs per document; MinerU variants alternate by document; RSS uses isolated process-tree sampling.
All first-run >5% time regressions passed reverse-order retests. The single first-run >5% shared RSS regression retested at 1.02646 and was not sustained. Full outputs were equal in every benchmark.
Focused profiling reduced
prepare_visual_evidence()from 0.703 s to 0.612 s across the 32-PDF source collection profile; the eight-document geometry stage decreased from 0.257527 s to 0.226503 s (12.0%). The Rust-owned textpage path executed 161/161 focus snapshots with no fallback, though_extract_owned_text_snapshot()remained approximately 0.529 s, showing that textpage wrapper creation itself was not the major raw-snapshot cost.Not done
dev@f504cffworktree and untrackedexamples/were not modified.