Repository navigation
PDF: reuse table grids and lane evidence - #31
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bboxnormalization with unchanged fallback semantics.Correctness
dev@f504cff: 31 eligible Flash text outputs and 32 actual medium shared outputs all matched the main baseline.-D warnings, rustfmt, and Ruff check passed. Changed-file formatting passed; 20 pre-existing unrelated files still fail full-repository ruff format and were not modified.bc42f1546006c340cb7175b5bbfa6698641a59057758c046a8f5f4c0bf5a222e; DocVortex core and MinerU Flash smoke outputs matched forautoandrust.Measured performance
One warmup plus five hot runs per document, alternating baseline/candidate execution order by document, with isolated process-tree RSS sampling. First-pass ratios above 5% were reverse-order retested; none persisted above 5%.
Reverse retests:
demo4.pdf0.94217;mixed_text_layout_sample.pdf.xor1.04183;quarterly_report_financial_tables.pdf0.98873.demo4.pdf0.96987;annual_report_research_projects_table.pdf0.93490;fund_asset_and_transaction_tables.pdf1.01703.mixed_elements_pages_03_06.pdf1.00299;small_ocr.pdf0.98000;pollutant_discharge_tables.pdf0.95873.One-pass 32-PDF profile reductions include
_detect_table_candidates6.821288 → 4.258895 s,_materialize_table_blocks5.383532 → 3.768801 s,_infer_text_lanes3.251807 → 2.474491 s, and_merge_owned_table_candidates2.223635 → 1.366970 s.The original 2× objective remains incomplete; this PR reports only measured gains.
Not done
examples/directory is preserved.