Repository navigation
docs: translate Chinese comments and docstrings into English - #34
Closed
humdrum00001010 wants to merge 1 commit into
Closed
humdrum00001010 wants to merge 1 commit into
humdrum00001010 wants to merge 1 commit into
Conversation
Author
|
It's a PR and also an idea proposal, if you dislike it, close! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chinese-only comments and docstrings make the PDF analysis and document conversion implementation difficult to follow for English-speaking contributors. Translate them into English across Python, Rust, tests, tools, workflow comments, CSS, and ignore-file comments. This is a machine-assisted translation with additional manual wording review of the PDF analysis entry points, EPUB renderer, and workflow comments. Preserve executable production code, identifiers, runtime strings, Chinese fixtures, and localized documentation.
The repository has no CONTRIBUTING.md or PR template. One existing architecture test explicitly required Chinese characters in renderer docstrings; make that guard language-neutral while retaining its requirement for responsibility descriptions. This is the only intentional executable-code change, and it is confined to the test guard.
Validation:
cargo test -p docvortex-core --locked: 15 passed; Rust formatting passes.Full cross-platform and Rust-backend validation remains to the upstream CI matrix.