Update Python wrapper to respect JAVA_HOME - #1110
Merged
Merged
Conversation
bocchino
changed the title
JAVA_HOME
Collaborator
Author
|
I'm blocking this PR until I understand the implications of this change. See the discussion in #1107. |
Enable error output
Import os
Don't set JAVA_HOME
Collaborator
Author
|
After some discussion with Claude, I'm OK with the general approach, but I wonder if we should have more error reporting. Also of note:
|
Collaborator
Author
|
A minimal approach to reporting (with no extra overhead) might be to say, in the error case, where we got the java from (JAVA_HOME or the PATH). That would at least say precisely what is wrong. |
bocchino
removed
the
blocked
Collaborator
Author
|
After discussion, we will report the source of the java (JAVA_HOME or path). |
bocchino
marked this pull request as draft
September 15, 2026 01:26
bocchino
marked this pull request as ready for review
September 15, 2026 04:36
thomas-bc
approved these changes
Sep 16, 2026
Kronos3
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1107.