Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…pod-rename-config-orcapodconfig-less-generic-clearer-in
There was a problem hiding this comment.
Pull request overview
This PR renames the core configuration type Config to OrcapodConfig across the codebase, updates all internal call sites and type hints accordingly, and exposes OrcapodConfig from the top-level orcapod package to make signatures/type hints more self-describing.
Changes:
- Renamed
src/orcapod/config.py: Config→OrcapodConfigand updatedDEFAULT_CONFIGto use the new type. - Updated imports/usages/type hints across core modules and operator tests to reference
OrcapodConfig. - Added tests verifying
OrcapodConfigimport paths, defaults,with_updates,merge, and top-level re-export viaorcapod.__all__.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_orcapod_config.py | Adds focused tests for OrcapodConfig import/behavior and top-level re-export. |
| tests/test_core/operators/test_operators.py | Updates local imports/usages from Config to OrcapodConfig in system-tag related tests. |
| tests/test_core/operators/test_merge_join.py | Updates local imports/usages from Config to OrcapodConfig in merge-join system-tag test. |
| superpowers/plans/2026-05-23-rename-config-to-orcapodconfig.md | Adds an implementation plan documenting the rename steps and verification commands. |
| src/orcapod/core/sources/stream_builder.py | Updates TYPE_CHECKING import and constructor type annotation to OrcapodConfig. |
| src/orcapod/core/sources/sqlite_table_source.py | Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/sources/spiraldb_table_source.py | Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/sources/postgresql_table_source.py | Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/sources/db_table_source.py | Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/sources/cached_source.py | Updates import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/sources/base.py | Updates import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/operators/static_output_pod.py | Updates import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/nodes/source_node.py | Updates import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/nodes/operator_node.py | Updates import and constructor config annotations to OrcapodConfig (multiple constructors). |
| src/orcapod/core/nodes/function_node.py | Updates import and constructor config annotations to OrcapodConfig (multiple constructors). |
| src/orcapod/core/function_pod.py | Updates import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/datagrams/datagram.py | Updates import and constructor config annotation to OrcapodConfig. |
| src/orcapod/core/data_function.py | Updates import and constructor config annotations to OrcapodConfig. |
| src/orcapod/core/base.py | Updates import and mixin/base constructor/property type hints to OrcapodConfig. |
| src/orcapod/config.py | Renames the config dataclass to OrcapodConfig and updates related type checks/messages/defaults. |
| src/orcapod/init.py | Re-exports OrcapodConfig at package top-level and adds it to __all__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Review round responseCopilot reviewed all 21 changed files and generated no specific comments — no code changes required. For completeness, the implementation covers:
All 3236 tests pass. |
Review round response (eywalker)No specific comments to address — eywalker approved the PR as-is. No code changes made in this round. The implementation is complete: |
Summary
Configclass insrc/orcapod/config.pytoOrcapodConfig— clearer in method signatures and type hints, self-describing wherever it appearsOrcapodConfigOrcapodConfigfrom the top-levelorcapodpackage (from orcapod import OrcapodConfig)tests/test_orcapod_config.pywith 8 tests covering import, instantiation,with_updates,merge, and top-level re-exportCloses ENG-514
Test Plan
uv run pytest tests/test_orcapod_config.py -v— all 8 tests passuv run pytest tests/ -m "not postgres and not minio and not integration" -q— 3144 passed, 0 failuresfrom orcapod import OrcapodConfigandfrom orcapod.config import OrcapodConfigboth workConfigimport references remain insrc/ortests/🤖 Generated with Claude Code