Skip to content

refactor(config): rename Config → OrcapodConfig - #142

Merged
eywalker merged 5 commits into
mainfrom
eywalker/eng-514-orcapod-rename-config-orcapodconfig-less-generic-clearer-in
May 23, 2026
Merged

eywalker merged 5 commits into
mainfrom
eywalker/eng-514-orcapod-rename-config-orcapodconfig-less-generic-clearer-in

Conversation

@kurodo3

@kurodo3 kurodo3 Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Renames the Config class in src/orcapod/config.py to OrcapodConfig — clearer in method signatures and type hints, self-describing wherever it appears
  • Updates all 15 internal source files and 2 test files to use OrcapodConfig
  • Exports OrcapodConfig from the top-level orcapod package (from orcapod import OrcapodConfig)
  • Adds tests/test_orcapod_config.py with 8 tests covering import, instantiation, with_updates, merge, and top-level re-export
  • No backward-compat alias — project is pre-v0.1.0 (per CLAUDE.md convention)

Closes ENG-514

Test Plan

  • uv run pytest tests/test_orcapod_config.py -v — all 8 tests pass
  • uv run pytest tests/ -m "not postgres and not minio and not integration" -q — 3144 passed, 0 failures
  • from orcapod import OrcapodConfig and from orcapod.config import OrcapodConfig both work
  • No stray bare Config import references remain in src/ or tests/

🤖 Generated with Claude Code

@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

…pod-rename-config-orcapodconfig-less-generic-clearer-in

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the core configuration type Config to OrcapodConfig across the codebase, updates all internal call sites and type hints accordingly, and exposes OrcapodConfig from the top-level orcapod package to make signatures/type hints more self-describing.

Changes:

  • Renamed src/orcapod/config.py: ConfigOrcapodConfig and updated DEFAULT_CONFIG to use the new type.
  • Updated imports/usages/type hints across core modules and operator tests to reference OrcapodConfig.
  • Added tests verifying OrcapodConfig import paths, defaults, with_updates, merge, and top-level re-export via orcapod.__all__.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_orcapod_config.py Adds focused tests for OrcapodConfig import/behavior and top-level re-export.
tests/test_core/operators/test_operators.py Updates local imports/usages from Config to OrcapodConfig in system-tag related tests.
tests/test_core/operators/test_merge_join.py Updates local imports/usages from Config to OrcapodConfig in merge-join system-tag test.
superpowers/plans/2026-05-23-rename-config-to-orcapodconfig.md Adds an implementation plan documenting the rename steps and verification commands.
src/orcapod/core/sources/stream_builder.py Updates TYPE_CHECKING import and constructor type annotation to OrcapodConfig.
src/orcapod/core/sources/sqlite_table_source.py Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig.
src/orcapod/core/sources/spiraldb_table_source.py Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig.
src/orcapod/core/sources/postgresql_table_source.py Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig.
src/orcapod/core/sources/db_table_source.py Updates TYPE_CHECKING import and constructor config annotation to OrcapodConfig.
src/orcapod/core/sources/cached_source.py Updates import and constructor config annotation to OrcapodConfig.
src/orcapod/core/sources/base.py Updates import and constructor config annotation to OrcapodConfig.
src/orcapod/core/operators/static_output_pod.py Updates import and constructor config annotation to OrcapodConfig.
src/orcapod/core/nodes/source_node.py Updates import and constructor config annotation to OrcapodConfig.
src/orcapod/core/nodes/operator_node.py Updates import and constructor config annotations to OrcapodConfig (multiple constructors).
src/orcapod/core/nodes/function_node.py Updates import and constructor config annotations to OrcapodConfig (multiple constructors).
src/orcapod/core/function_pod.py Updates import and constructor config annotation to OrcapodConfig.
src/orcapod/core/datagrams/datagram.py Updates import and constructor config annotation to OrcapodConfig.
src/orcapod/core/data_function.py Updates import and constructor config annotations to OrcapodConfig.
src/orcapod/core/base.py Updates import and mixin/base constructor/property type hints to OrcapodConfig.
src/orcapod/config.py Renames the config dataclass to OrcapodConfig and updates related type checks/messages/defaults.
src/orcapod/init.py Re-exports OrcapodConfig at package top-level and adds it to __all__.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kurodo3

kurodo3 Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

Review round response

Copilot reviewed all 21 changed files and generated no specific comments — no code changes required.

For completeness, the implementation covers:

  • Class rename: ConfigOrcapodConfig in src/orcapod/config.py (class definition, merge() type checks and annotations, DEFAULT_CONFIG)
  • 15 source files: all imports and type hints updated to OrcapodConfig
  • 2 test files: local imports updated (test_operators.py, test_merge_join.py)
  • Top-level export: OrcapodConfig added to src/orcapod/__init__.py and __all__
  • New tests: tests/test_orcapod_config.py — 8 tests covering import paths, defaults, with_updates, merge, type error, and top-level re-export
  • No backward-compat alias — per project CLAUDE.md (greenfield pre-v0.1.0)

All 3236 tests pass.

@eywalker
eywalker merged commit 613e691 into main May 23, 2026
11 checks passed
@kurodo3

kurodo3 Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

Review round response (eywalker)

No specific comments to address — eywalker approved the PR as-is. No code changes made in this round.

The implementation is complete: ConfigOrcapodConfig renamed across all 20 source/test files, top-level export added, 3236 tests passing.

@eywalker
eywalker deleted the eywalker/eng-514-orcapod-rename-config-orcapodconfig-less-generic-clearer-in branch May 23, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants