Repository navigation
v5.0.0: one name per config key (output_basename everywhere); refuse RNEAT_ read names (#879) - #880
Open
joshfactorial wants to merge 4 commits into
Open
joshfactorial wants to merge 4 commits into
joshfactorial wants to merge 4 commits into
Conversation
…d names (#879) MAJOR, for v5.0.0. Config keys and their meaning are public API (docs-site/src/reference/versioning.md). - gen-reads: `output_filename` becomes `output_prefix`, the name gen-cancer-reads already used. The old name is refused with "removed in v5.0.0; use `output_prefix`". - gen-cancer-reads: drops its second names `output_filename`, `coverage` and `rng_seed_root`, each refused naming `output_prefix`, `total_coverage` or `rng_seed`. - filter-reads: a `@RNEAT_generated_` read is an error naming the prefix and the sed fix. It was read with a warning. It must not fall through as an ordinary line, which would drop every read at exit 0. - Every repo config, template, test, doc and script uses output_prefix. New page: Upgrading from 4.x. Tests: config_errors_exit_cleanly gains three (each removed gen-reads and cancer key, and an RNEAT FASTQ), each failing under its mutant (the alias re-added; the RNEAT check disabled). The filter_lib unit test now requires the RetiredPrefix error. The existing suite exercises output_prefix throughout, which is the must-not-fire side. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rce config (#879) The 21x simulation config already on Delta scratch carries output_filename, which v5 refuses, so it is stripped along with output_prefix before the benchmark appends its own. output_prefix is read by every release since the rename, so the script still runs against the develop binary. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
#879) 'prefix' reads as path-plus-prefix in samtools, bwa and STAR. The key holds a file name only, joined to output_dir. Both subcommands now refuse output_prefix with a rename hint, and refuse a value containing / or \ (an absolute path silently replaced output_dir; a relative subdirectory failed with a bare I/O error). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #879 (close by hand on merge to
develop).MAJOR change, for v5.0.0. Config keys and their meaning are public API under
docs-site/src/reference/versioning.md.Change
output_basename. "Prefix" reads as path-plus-prefix in samtools, bwa and STAR; this key is a file name only, joined tooutput_dir.output_prefix(gen-cancer-reads, and NEAT's name) is refused with`output_prefix` (renamed `output_basename` in v5.0.0)./or\is an error namingoutput_dir. Before, an absolute path silently replacedoutput_dirandsub/runfailed with a bare I/O error.output_filenameis refused with`output_filename` (removed in v5.0.0; use `output_basename`).output_filename→output_basename;coverage→total_coverage;rng_seed_root→rng_seed.@RNEAT_generated_is now an error, where it used to be read with a warning. The error names the prefix and gives thesedcommand that renames it. It must not fall through as an ordinary line:filter_fastqwould then drop every read and still exit 0.output_basename: Rust tests, templates, README, docs-site,scripts/delta,tools.The internal
RunConfigurationfield is renamed to match. That is not public API.Evidence
New tests in
config_errors_exit_cleanly.rs: each removed gen-reads and gen-cancer-reads key, and a FASTQ with anRNEAT_generated_read. Each requires exit 1, no panic, and the replacement named on stderr.Mutation checks, each confirmed applied and then restored with
cmp:output_filenameback in gen-reads' accepted keysoutput_basename_with_a_path_separator_is_refusedfailscoverageback in gen-cancer-reads' accepted keysUnit test: the
filter_libtest now requires theRetiredPrefixerror.Rename tests:
output_prefixis refused namingoutput_basenamein both subcommands;sub/run,/abs/runanda\bare each refused in both.Must not fire: the whole existing suite now writes
output_basenameand passes.The workspace suite passes: 63 test binaries pass on the last run. Earlier in the branch
invoked_namefailed once at its copy-and-exec step and passed 3 of 3 on its own and on rerun. Clippy-D warningsand fmt pass.Not verified
scripts/deltaandtoolsedits were checked withbash -nonly, not run. Each is a one-word key rename inside a heredoc or printf.\\on every platform, so a file name containing a literal backslash is refused on Linux too.output_prefixwas its key since before 4.x). The upgrade page has a one-linesedfor them.🤖 Generated with Claude Code