Repository navigation
feat(statistics): add tdigest implementation and related functions - #1456
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a complete t-digest implementation for efficient quantile estimation in the statistics module. The t-digest is a data structure designed for accurate on-line accumulation of rank-based statistics such as quantiles and cumulative distribution functions, particularly effective for large datasets and extreme quantile estimation.
- Implementation of a tdigest class with configurable compression parameters
- Support for percentile and quantile methods with streaming data updates via the + operator
- Comprehensive test coverage and documentation including examples and benchmarks
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/statistics/functions/@tdigest/*.m | Core tdigest class implementation with methods for quantile estimation, compression, and data addition |
| modules/statistics/tests/test_tdigest.m | Test suite covering various scenarios including edge cases with NaN values |
| modules/statistics/tests/bench_tdigest.m | Performance benchmark for tdigest operations |
| modules/statistics/help/en_US/xml/tdigest.xml | Complete documentation with usage examples and method descriptions |
| modules/statistics/module.iss | Installation configuration for tdigest class files |
| modules/statistics/CMakeLists.txt | Build system configuration for tdigest installation |
| CHANGELOG.md | Documentation of the new tdigest feature |
Comments suppressed due to low confidence (2)
modules/statistics/tests/bench_tdigest.m:1
- [nitpick] Missing space after assignment operator. Should be 'a = 1:5000;' for consistency with coding style.
%=============================================================================
modules/statistics/tests/bench_tdigest.m:1
- [nitpick] Missing space after assignment operator. Should be 'a = 5000:-1:1;' for consistency with coding style.
%=============================================================================
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Add tdigest class and associated methods for efficient quantile estimation.
Nelson-numerical-software
force-pushed
the
t-digest
branch
from
September 10, 2025 13:52
ed1c98c to
9253a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tdigest class and associated methods for efficient quantile estimation.