Skip to content

feat(python_engine): support python 3.14 - #1468

Merged
Nelson-numerical-software merged 1 commit into
masterfrom
python-3.14-support
Oct 19, 2025
Merged

Nelson-numerical-software merged 1 commit into
masterfrom
python-3.14-support

Conversation

@Nelson-numerical-software

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Add Python 3.14 support by updating symbol resolution for file-opening APIs and aligning internal wrappers, plus CI and docs updates.

  • Add dynamic resolution for Python’s file-open symbol to support new/old names.
  • Rename internal wrapper from NLS_Py_fopen_obj to NLS_Py_fopen and update call sites.
  • Update CI to use Python 3.14 and note support in CHANGELOG.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
modules/python_engine/src/cpp/PythonLibraryWrapper.hpp Renames wrapper declaration to NLS_Py_fopen to reflect broader symbol support.
modules/python_engine/src/cpp/PythonLibraryWrapper.cpp Adds fallback loading for Python’s fopen symbol; updates typedef and wrapper logic.
modules/python_engine/src/cpp/PythonFileRunner.cpp Updates call to the renamed wrapper.
.github/workflows/ccpp_windows.yml Bumps setup-python to 3.14 in CI.
CHANGELOG.md Notes Python 3.14 support.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread modules/python_engine/src/cpp/PythonLibraryWrapper.cpp
Comment thread modules/python_engine/src/cpp/PythonLibraryWrapper.cpp
Comment thread modules/python_engine/src/cpp/PythonLibraryWrapper.cpp
Comment thread modules/python_engine/src/cpp/PythonLibraryWrapper.cpp
Comment thread modules/python_engine/src/cpp/PythonLibraryWrapper.hpp
@Nelson-numerical-software
Nelson-numerical-software merged commit b35ce6d into master Oct 19, 2025
34 of 35 checks passed
@Nelson-numerical-software
Nelson-numerical-software deleted the python-3.14-support branch October 19, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants