Repository navigation
feat(python_engine): support python 3.14 - #1468
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Add Python 3.14 support by updating symbol resolution for file-opening APIs and aligning internal wrappers, plus CI and docs updates.
- Add dynamic resolution for Python’s file-open symbol to support new/old names.
- Rename internal wrapper from NLS_Py_fopen_obj to NLS_Py_fopen and update call sites.
- Update CI to use Python 3.14 and note support in CHANGELOG.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/python_engine/src/cpp/PythonLibraryWrapper.hpp | Renames wrapper declaration to NLS_Py_fopen to reflect broader symbol support. |
| modules/python_engine/src/cpp/PythonLibraryWrapper.cpp | Adds fallback loading for Python’s fopen symbol; updates typedef and wrapper logic. |
| modules/python_engine/src/cpp/PythonFileRunner.cpp | Updates call to the renamed wrapper. |
| .github/workflows/ccpp_windows.yml | Bumps setup-python to 3.14 in CI. |
| CHANGELOG.md | Notes Python 3.14 support. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.