Skip to content

Ctrl f search - #1470

Merged
Nelson-numerical-software merged 2 commits into
masterfrom
ctrl-F-search
Oct 23, 2025
Merged

Nelson-numerical-software merged 2 commits into
masterfrom
ctrl-F-search

Conversation

@Nelson-numerical-software

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive search feature (Ctrl+F) across both the text editor and terminal console components, addressing the need for text search functionality in the application's GUI.

Key Changes:

  • Added find/find next/find previous functionality with keyboard shortcuts (Ctrl+F, F3, Shift+F3)
  • Implemented cursor position and encoding status display in the text editor
  • Improved drag-and-drop handling for file opening with better URL and text support

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
modules/text_editor/src/cpp/QtTextEditor.h Declares find actions, status label, and related member variables/methods
modules/text_editor/src/cpp/QtTextEditor.cpp Implements find dialog, search navigation, status bar updates, and improved drag-drop handling
modules/gui/src/cpp/QtTerminal.h Declares find actions and helper methods for text formatting
modules/gui/src/cpp/QtTerminal.cpp Implements find functionality and optimizes text rendering with edit blocks
CHANGELOG.md Documents the new search feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread modules/gui/src/cpp/QtTerminal.cpp Resolved
Comment thread modules/gui/src/cpp/QtTerminal.cpp Resolved
Comment thread modules/gui/src/cpp/QtTerminal.cpp Resolved
@Nelson-numerical-software
Nelson-numerical-software merged commit b62266c into master Oct 23, 2025
1 check passed
@Nelson-numerical-software
Nelson-numerical-software deleted the ctrl-F-search branch October 23, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants