Repository navigation
feat(eye): handle case for eye without input arguments - #1471
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for calling the eye function without any input arguments, which should return a 1×1 identity matrix (equivalent to eye(1, 1)).
- Refactored the
eyeBuiltinfunction to extract argument parsing logic into helper functions - Added test coverage for the no-argument case of
eye - Updated the changelog to document the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/constructors_functions/builtin/cpp/eyeBuiltin.cpp | Refactored into helper functions extractDestClassAndSparse and parseDimensions to support the no-argument case |
| modules/constructors_functions/tests/test_eye.m | Added test case verifying that eye without arguments returns a 1×1 identity matrix |
| CHANGELOG.md | Documented the new feature for eye without input arguments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Nelson-numerical-software
force-pushed
the
fix-eye-no-rhs
branch
from
October 23, 2025 17:58
c52482e to
ed9549e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.