Repository navigation
feat: pascal, gallery functions - #1478
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new matrix generation functions to the elementary_functions module, specifically pascal and gallery functions for creating test matrices commonly used in numerical algorithms. The changes include function implementations, documentation in both English and French, comprehensive test coverage, and build system updates.
Key changes:
- Implementation of
pascalfunction to generate Pascal's triangle matrices with different orientations - Implementation of
galleryfunction supporting 17 different matrix families for testing numerical algorithms - Addition of 16 private helper functions for specific matrix families
- Test file updates including a refactored memory leak test and new test files for the added functions
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/elementary_functions/functions/pascal.m | Main implementation of Pascal matrix generator |
| modules/elementary_functions/functions/gallery.m | Main dispatch function for gallery matrix families |
| modules/elementary_functions/functions/private/*.m | 16 private helper functions implementing specific matrix families |
| modules/elementary_functions/tests/test_pascal.m | Comprehensive tests for pascal function |
| modules/elementary_functions/tests/test_gallery.m | Extensive tests covering all gallery matrix families |
| modules/interpreter/tests/bug_interpreter_leak_2.m | Refactored test to use hardcoded macro list for reproducibility |
| modules/elementary_functions/help/en_US/xml/pascal.xml | English documentation for pascal function |
| modules/elementary_functions/help/fr_FR/xml/pascal.xml | French documentation for pascal function |
| modules/elementary_functions/help/en_US/xml/gallery.xml | English documentation for gallery function with detailed matrix family descriptions |
| modules/elementary_functions/help/fr_FR/xml/gallery.xml | French documentation for gallery function |
| modules/elementary_functions/module.iss | Installer configuration update for private functions |
| modules/elementary_functions/CMakeLists.txt | Build system update to install private functions |
| CHANGELOG.md | Documentation of new features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nelson-numerical-software
force-pushed
the
gallery
branch
from
November 2, 2025 10:34
bd02b0a to
9cc867e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
modules/elementary_functions/functions/private/house.m:1
- Missing lower bound validation. The 'house' case in gallery.m doesn't validate that at least 2 arguments are provided (matrixname + inputVector). This should include
nargin() < 2check to ensure the required inputVector argument is present.
%=============================================================================
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.