Repository navigation
feat: new functions subspace, maxk, mink, downsample, findpeaks, std - #1483
Merged
Nelson-numerical-software merged 1 commit intoNov 11, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds six new mathematical and signal processing functions to Nelson, enhancing the software's statistical analysis, signal processing, and linear algebra capabilities. The changes include implementations in MATLAB-compatible syntax, comprehensive test coverage, and bilingual documentation.
Key additions:
- Statistical functions:
std(standard deviation) - Signal processing:
findpeaks(local maxima detection),downsample(signal decimation) - Elementary functions:
minkandmaxk(k smallest/largest elements) - Data analysis:
subspace(angle between subspaces)
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/statistics/functions/std.m | Implements standard deviation by wrapping the variance function |
| modules/statistics/tests/test_std.m | Test cases for std function covering various input scenarios |
| modules/statistics/help/en_US/xml/std.xml | English documentation for std function |
| modules/statistics/help/fr_FR/xml/std.xml | French documentation for std function |
| modules/signal_processing/functions/findpeaks.m | Complex peak detection algorithm with multiple filtering options |
| modules/signal_processing/tests/test_findpeaks.m | Comprehensive test suite for findpeaks functionality |
| modules/signal_processing/help/en_US/xml/findpeaks.xml | English documentation for findpeaks function |
| modules/signal_processing/help/fr_FR/xml/findpeaks.xml | French documentation for findpeaks function |
| modules/signal_processing/functions/downsample.m | Implements signal downsampling with phase offset support |
| modules/signal_processing/tests/test_downsample.m | Test cases for downsample function |
| modules/signal_processing/help/en_US/xml/downsample.xml | English documentation for downsample function |
| modules/signal_processing/help/fr_FR/xml/downsample.xml | French documentation for downsample function |
| modules/elementary_functions/functions/mink.m | Returns k smallest elements along specified dimension |
| modules/elementary_functions/tests/test_mink.m | Test cases for mink function |
| modules/elementary_functions/help/en_US/xml/mink.xml | English documentation for mink function |
| modules/elementary_functions/help/fr_FR/xml/mink.xml | French documentation for mink function |
| modules/elementary_functions/functions/maxk.m | Returns k largest elements along specified dimension |
| modules/elementary_functions/tests/test_maxk.m | Test cases for maxk function |
| modules/elementary_functions/help/en_US/xml/maxk.xml | English documentation for maxk function |
| modules/elementary_functions/help/fr_FR/xml/maxk.xml | French documentation for maxk function |
| modules/data_analysis/functions/subspace.m | Computes angle between subspaces using SVD |
| modules/data_analysis/tests/test_subspace.m | Test case for subspace function |
| modules/data_analysis/help/en_US/xml/subspace.xml | English documentation for subspace function |
| modules/data_analysis/help/fr_FR/xml/subspace.xml | French documentation for subspace function |
| CHANGELOG.md | Documents the addition of the new functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nelson-numerical-software
force-pushed
the
maxk-mink-findpeaks-downsample-std-subspace-functions
branch
from
November 10, 2025 18:12
0f5fa66 to
51ea56e
Compare
Nelson-numerical-software
force-pushed
the
maxk-mink-findpeaks-downsample-std-subspace-functions
branch
from
November 10, 2025 18:49
51ea56e to
4ca13c4
Compare
Nelson-numerical-software
deleted the
maxk-mink-findpeaks-downsample-std-subspace-functions
branch
November 11, 2025 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.