Repository navigation
fix #2 extends insert and extract sparse matrix (first step) - #1485
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for inserting and extracting sparse matrix elements, adds contour labeling functionality, extends colormap location support, and adds VS 2026 support. Key changes include:
- Implementation of sparse matrix insertion/extraction operations (GitHub issue #2)
- Addition of
clabelfunction for contour plot labeling - Extended
colorbarwith support for multiple location parameters - Addition of Lehmer matrix to the gallery function
- Support for Visual Studio 2026
- Performance improvements in SVD computation and eigenvalue decomposition
- Bug fixes for line graphics properties
Reviewed Changes
Copilot reviewed 32 out of 38 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/sparse/tests/bug_github_issue_2.m | Test cases for sparse matrix insertion and extraction |
| modules/sparse/src/cpp/SparseType.cpp | Core implementation of sparse matrix operations |
| modules/linear_algebra/src/cpp/SVD.cpp | SVD optimization using gesdd and improved transpose |
| modules/linear_algebra/src/cpp/EigenLapackHelpers.cpp | Eigenvalue decomposition optimization |
| modules/interpreter/src/cpp/NelsonLexer.cpp | Lexer fix for matrix ellipsis handling |
| modules/graphics/src/cpp/GOLineSeries.cpp | Line graphics property initialization fix |
| modules/graphics/help/*/xml/clabel.xml | Documentation for new clabel function |
| modules/graphics/help/*/xml/colorbar.xml | Updated colorbar documentation |
| modules/elementary_functions/functions/gallery.m | Added Lehmer matrix support |
| modules/dynamic_link/resources/msvc2026.json | VS 2026 configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clabel: Contour labeling.colormap: added support for the following locationsnorth,south,east,west,northoutside,southoutside,eastoutside, andwestoutside.