Repository navigation
refactor: replace JavaScript navigation with links - #8879
Conversation
|
@odzhychko Can you please have a look at this PR as it addresses your issue ticket |
71df6f7 to
9cccc9b
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
odzhychko
left a comment
There was a problem hiding this comment.
Review is still in progress from my side.
Looks good
- src/components/AppNavigation/Proposal/ProposalList.vue
- src/components/AppointmentConfigModal/NoEmailAddressWarning.vue
Revert
AttachmentsList.vue uses non-link buttons to warn users about external links. Lets keep the implementation as is there for now. I would have to think about, what would be good behavior there first.
Still need to check
I still need to check src/fullcalendar to make sure, this is how it is intended to be solved in Fullcalendar and has no unintended side effects.
23ff726 to
144d045
Compare
odzhychko
left a comment
There was a problem hiding this comment.
Some cases for task links need work.
144d045 to
94da13f
Compare
Assisted-by: Codex:gpt-5 Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
Assisted-by: Codex:gpt-5 Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
94da13f to
8276393
Compare
odzhychko
left a comment
There was a problem hiding this comment.
Code looks good to me and works as expected.
Summary
Closes: #8811