feat: inline comments by mejo- · Pull Request #8901 · nextcloud/text

mejo- · 2026-07-22T15:43:18Z

📝 Summary

This PR implement inline point-anchor comments as discussed in #185.

Comments can be inserted via toolbar submenu, by typing [?] or by pressing Ctrl-Alt-M
A superscript chat bubble icon (💬) marks the comment anchor in the text. Clicking it opens the comment bubble
Inside the comment bubble, one can add, edit and remove replies
Comments and footnotes can be hidden to improve legibility via "Hide annotations" in the toolbar submenu
Resolves: Inline comments #185

Markdown representation

Comments are stored using the footnote syntax already supported by Text, with a comment- prefix to distinguish them from regular footnotes:

The quick[^comment-1] brown fox.

[^comment-1]:
    - @[jane](mention://user/jane) *(2026-05-21T10:30Z)*
      Is "quick" the right word here?
    - @[bob](mention://user/bob) *(2026-05-21T12:45Z)*
      I think "fast" is more accurate.

Existing Markdown editors with footnote support (Obsidian, Ghostwriter) render the comment definitions as footnotes and make them accessible.

🖼️ Screenshots

Toolbar submenu	Comment bubble	Entering first comment reply	Editing a reply

🖼️ Screencast

Warning

Wait till the end, there's a long pause in between!

🚧 TODO

~~Regression: Undo is now always disabled in toolbar~~
~~Would be great if adding/editing/deleting replies could be undoable as well~~ edit: turns out it already is 🎉
Support to mention users in comments
Optionally replace NcRichContenteditable with a stripped-down Text editor for editing comments and replies

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

The content of this PR was partly generated using AI tools
The AI-generated content was reviewed, comprehended and tested by a human

The plugin post-processes data from footnotes plugin. As we cannot change the label parsing rules of the footnotes plugin, this seemed to be the most sensible thing to do. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-opus-4-8

The comments container is hidden in UI for now. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Signed-off-by: Jonas <jonas@freesources.org>

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Signed-off-by: Jonas <jonas@freesources.org>

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Makes sure the input field is focussed when the comment bubble opens. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Also use a fixed width to avoid visible container growth when opening a comment bubble with long comments. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

* Use NcRichContenteditable as input field * Use ProseMirror DOMSerializer to turn commentItem content into HTML and render it with Vue v-html. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

Signed-off-by: Jonas <jonas@freesources.org>

The command is registered in an own Tiptap extenstion that requires a browser. In the comment node unit tests, we don't have this extension loaded. Signed-off-by: Jonas <jonas@freesources.org>

silverkszlo · 2026-07-23T09:26:17Z

+	return result
+})
+
+const isFirstComment = computed(() => items.value.length === 0 || (items.value.length === 1 && !items.value[0].body))


The button only ever renders "Reply" and never "Comment", even when it's the first comment. Claude says, that isFirstComment compares serialized HTML ("<p></p>") and not real emptiness, so it's always false and therefore only shows "Reply".

mejo- requested a review from marcoambrosini July 22, 2026 15:43

mejo- self-assigned this Jul 22, 2026

mejo- requested review from max-nextcloud and silverkszlo as code owners July 22, 2026 15:43

mejo- added the enhancement New feature or request label Jul 22, 2026

mejo- added this to 📝 Productivity team Jul 22, 2026

mejo- added 2. developing format: markdown labels Jul 22, 2026

github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Jul 22, 2026

mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Productivity team Jul 22, 2026

mejo- force-pushed the feat/comments branch 2 times, most recently from e27b832 to 0ecbdff Compare July 23, 2026 07:41

mejo- added 18 commits July 23, 2026 09:56

feat(editor): add Tiptap nodes for comments support

fea01d6

The comments container is hidden in UI for now. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(FloatingButtons): don't display for comment nodes

c8bc244

Signed-off-by: Jonas <jonas@freesources.org>

chore(footnotes): move helper functions into a separate file

98c9640

Signed-off-by: Jonas <jonas@freesources.org>

chore(referenceHelpers): rework functions to be usable with comments

154cdca

Signed-off-by: Jonas <jonas@freesources.org>

feat(comments): add insertComment Tiptap command

d8d02c8

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(HelpModal): document comments syntax and shortcut

34b8c3b

Signed-off-by: Jonas <jonas@freesources.org>

feat(comments): add plugins and views to display comment threads

5451f1a

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(comments): add menu entry and allow to hide annotations

e1fca1a

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(comments): add support for inserting comment item body

d807ac9

Makes sure the input field is focussed when the comment bubble opens. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(CommentBubbleView): improve layout with long comment threads

b4d7c66

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(CommentBubble): place bubble to the right of the editor container

6879845

Also use a fixed width to avoid visible container growth when opening a comment bubble with long comments. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(CommentBubble): support rich editing in comments

cc22faf

* Use NcRichContenteditable as input field * Use ProseMirror DOMSerializer to turn commentItem content into HTML and render it with Vue v-html. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(comments): allow to edit comment replies

bf5f459

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(comments): prompt for nick before guest can comment

5d90b51

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(comments): add " (guest)" to displayed author if a guest comment

85ccf22

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(comments): hide comments editing UI when editor is readonly

ab3170d

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

test(playwright): test comments feature

35d7b00

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

mejo- added 5 commits July 23, 2026 09:57

fix(comments): persist reply draft across bubble close+open

266ec75

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

feat(comments): allow to delete comment replies

ab90bcd

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(comments): fix editor.can() with insertComment command

9fc72c3

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5

fix(CommentBubble): focus input fields on open

7b32665

Signed-off-by: Jonas <jonas@freesources.org>

fix(CommentReference): don't use openCommentBubble command

8eda11e

The command is registered in an own Tiptap extenstion that requires a browser. In the comment node unit tests, we don't have this extension loaded. Signed-off-by: Jonas <jonas@freesources.org>

mejo- force-pushed the feat/comments branch from 0ecbdff to 8eda11e Compare July 23, 2026 08:28

silverkszlo reviewed Jul 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: inline comments#8901

feat: inline comments#8901
mejo- wants to merge 23 commits into
mainfrom
feat/comments

mejo- commented Jul 22, 2026 •

edited

Loading

Uh oh!

silverkszlo Jul 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mejo- commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

Markdown representation

🖼️ Screenshots

🖼️ Screencast

🚧 TODO

🏁 Checklist

🤖 AI (if applicable)

Uh oh!

silverkszlo Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mejo- commented Jul 22, 2026 •

edited

Loading

silverkszlo Jul 23, 2026 •

edited

Loading