Repository navigation
fix(config): use defaults when .testyrc.json is missing for explicit files - #440
Merged
Merged
Conversation
…explicit files Configuration.withConfiguration (used when test files are passed on the CLI) read .testyrc.json without the fallback that Configuration.current() had, so running a single file from a directory without that file crashed through the generic unexpected-error path. Both now share the same optional read. Closes #439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Corrige #439:
npx testy some_test.jsdesde un directorio sin.testyrc.jsonfallaba con el error genérico "unexpected error" (ENOENT).Por qué pasaba
Configuration.current()tenía un fallback a{}si no existía el archivo de usuario, peroConfiguration.withConfiguration()(el camino usado cuando se pasan archivos por CLI) leía.testyrc.jsonsin ese fallback.Cambio
#userConfigurationFile(), que devuelve{}si el archivo no se puede leer;current()delega enwithConfiguration({}).bin/testy_cli.jssobre un archivo en un directorio temporal sin.testyrc.json(falla antes del fix, pasa después).Closes #439
🤖 Generated with Claude Code