Repository navigation
Fail clearly when the default API key has no name - #363
Merged
Merged
Conversation
With authentication.type=api_key, the default security scheme has no name, so without authentication.api-key-name the name lookup threw a NullPointerException, instead of the error saying which property to set. Specs can't trigger this, because the parser rejects apiKey schemes without a name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
authentication.type=api_key, the default security scheme has no name, so withoutauthentication.api-key-namethe name lookup threw aNullPointerException(defaultObj), instead of theINVALID_CATALOG_PROPERTYerror saying which property to set.The issue also mentions
apiKeyschemes in the spec without aname, but those can't reach this code: the parser rejects them when the spec loads, withOPENAPI_INVALID_SPEC.Fixes #360