Repository navigation
fix(toasts): notified gives one answer whatever it opened - #137
Merged
Merged
Conversation
It returned "shown" for a toasted or unread chat and "opened" otherwise, so a same-user process could learn whether a chat id was unread or had just been toasted by calling it and reading the reply. It now always returns "opened"; what it opens is unchanged. Raised in the nixfred#136 review.
Owner
|
Merged, thank you Ian, and for turning a review footnote into a fix within the hour. One answer whatever happened, and the test that pins exactly one return value means it stays that way. Live on both my machines: an unknown id and a known chat both answer "opened". |
nixfred
added a commit
that referenced
this pull request
Oct 8, 2026
LR-T: blip, change-log, weekly-notes, #137, ianswope LR-D: blip Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeRMdPWNC2myz9U8hEeeCi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the note on #136.
notifiedreturned"shown"when it opened a toasted or still-unread chat and"opened"otherwise, so a same-user process could probe whether a chat id was unread or had just been toasted. It now always returns"opened". What a click opens is unchanged.Verified
bun test: 750 pass, including a test thatopenNotifiedhas exactly one return value.notified 15550100001andnotified ""both answeropened.