fix: write pch cflags as a list instead of a map object - #355
Open
PickBas wants to merge 1 commit into
Open
Conversation
cclauss
reviewed
Aug 24, 2026
cclauss
reviewed
Aug 24, 2026
Refs: nodejs/node#57633 Signed-off-by: PickBas <sayed.kirill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GetFlagsModificationsreturnedmapobjects forcflags_c/cflags_cc.The
/Ycflag never reachedcl.exe, so precompiled headers were broken for every ninja build on Windows.Fix
Replace both
map()calls with list comprehensions.Test
test_ninja_precompiled_headerruns the ninja generator over a new PCH fixture and asserts the flags are written out instead of amapobject.Refs: nodejs/node#57633