net: support TCP handle transfer on Windows#64460
Open
mcollina wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64460 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 741 741
Lines 241603 241596 -7
Branches 45523 45530 +7
==========================================
- Hits 218038 218022 -16
+ Misses 15109 15100 -9
- Partials 8456 8474 +18
π New features to boost your workflow:
|
jasnell
approved these changes
Jul 12, 2026
StefanStojanovic
approved these changes
Jul 13, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
mcollina
added
the
commit-queue
marco-ippolito
approved these changes
Jul 14, 2026
Member
Author
|
DO you know why the test-internt job is failing? |
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64460 β Done loading data for nodejs/node/pull/64460 ----------------------------------- PR info ------------------------------------ Title net: support TCP handle transfer on Windows (#64460) Author Matteo Collina <matteo.collina@gmail.com> (@mcollina) Branch mcollina:tcp-transfer-windows -> nodejs:main Labels c++, lib / src, needs-ci Commits 1 - net: support TCP handle transfer on Windows Committers 1 - Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/64460 Fixes: https://github.com/nodejs/node/issues/64456 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64460 Fixes: https://github.com/nodejs/node/issues/64456 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Sun, 12 Jul 2026 19:21:24 GMT β Approvals: 3 β - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64460#pullrequestreview-4680793259 β - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/64460#pullrequestreview-4682937899 β - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/64460#pullrequestreview-4695725787 β 1 GitHub CI job(s) failed: β - test-internet: FAILURE (https://github.com/nodejs/node/actions/runs/29205638124/job/87130276315) βΉ Last Full PR CI on 2026-07-13T18:49:42Z: https://ci.nodejs.org/job/node-test-pull-request/74791/ - Querying data for job/node-test-pull-request/74791/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/29363329109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Windows support for transferring TCP handles across worker threads.
Fixes: #64456