lib: enable web worker api by default - #65323
Open
avivkeller wants to merge 1 commit into
Open
Conversation
avivkeller
added
the
semver-major
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65323 +/- ##
==========================================
- Coverage 90.16% 90.15% -0.01%
==========================================
Files 751 751
Lines 253465 253465
Branches 47741 47741
==========================================
- Hits 228537 228520 -17
- Misses 16197 16209 +12
- Partials 8731 8736 +5
🚀 New features to boost your workflow:
|
aduh95
reviewed
Aug 17, 2026
Contributor
There was a problem hiding this comment.
You'd need to also add the changes entry and update the link at
Lines 1313 to 1320 in 8b9f89f
panva
approved these changes
Aug 21, 2026
panva
added
the
commit-queue-squash
panva
approved these changes
Aug 22, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
Bot
removed
the
request-ci
Collaborator
Signed-off-by: avivkeller <me@aviv.sh>
avivkeller
force-pushed
the
web-worker-default-enable
branch
from
August 24, 2026 05:11
67ca30a to
1996a2a
Compare
Member
Author
|
Needs a re-approval |
panva
approved these changes
Aug 25, 2026
aduh95
reviewed
Aug 25, 2026
| description: This feature is now enabled by default. | ||
| --> | ||
|
|
||
| > Stability: 1 - Experimental. Enable this API with the |
Contributor
There was a problem hiding this comment.
Suggested change
| > Stability: 1 - Experimental. Enable this API with the | |
| > Stability: 1 - Experimental. Disable this API with the |
As mentioned in #65323 (review), you also need to update the link (we need to get back some kind of automation to detect broken links)
Member
Author
There was a problem hiding this comment.
(we need to get back some kind of automation to detect broken links)
We have one in @node-core/remark-lint, but I've put integrating it into core on hold, I can revisit
Contributor
|
We probably need a regression test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @panva
Ref: #64894
Ref: #43583
Makes web worker support enabled by default