Skip to content

doc: fix stale TOC in maintaining-dependencies - #65523

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
greenheadHQ:fix/maintaining-dependencies-toc
Aug 29, 2026
Merged

doc: fix stale TOC in maintaining-dependencies#65523
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
greenheadHQ:fix/maintaining-dependencies-toc

Conversation

@greenheadHQ

Copy link
Copy Markdown
Contributor

The dependency list still links to base64, which was removed in #52714, so this drops the leftover TOC entry and its link definition.

It also restores the icu-small heading that was accidentally truncated to ic in #51195 while removing version numbers, so the existing [icu-small] TOC link resolves to a real anchor again.

Remove the base64 entry left behind when the dependency was removed,
and rename the `ic` heading to `icu-small` so the TOC link resolves.

Signed-off-by: greenhead <shren0812@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Aug 24, 2026
@daeyeon daeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 29, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 03924f6 into nodejs:main Aug 29, 2026
27 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 03924f6

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2026
aduh95 pushed a commit that referenced this pull request Aug 29, 2026
Remove the base64 entry left behind when the dependency was removed,
and rename the `ic` heading to `icu-small` so the TOC link resolves.

Signed-off-by: greenhead <shren0812@gmail.com>
PR-URL: #65523
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants