Skip to content

tools: label PRs lacking second approval - #65538

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:commit-queue-approval-label
Closed

tools: label PRs lacking second approval#65538
panva wants to merge 1 commit into
nodejs:mainfrom
panva:commit-queue-approval-label

Conversation

@panva

@panva panva commented Aug 25, 2026

Copy link
Copy Markdown
Member

Pull requests in the commit queue that are at least two days old and lack a 2nd approval get labeled with lacks-second-approval. This makes it visible why the pull request has not landed yet and helps collaborators find pull requests that need another review.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from aduh95 August 25, 2026 10:43
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 25, 2026
panva added a commit to nodejs/node-auto-test that referenced this pull request Aug 26, 2026
Enable the commit queue in node-auto-test.

Treat queued PRs as aged so PR 103 exercises the approval label.

PR-URL: nodejs/node#65538

Assisted-by: Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva added a commit to nodejs/node-auto-test that referenced this pull request Aug 26, 2026
Enable the commit queue in node-auto-test.

Treat queued PRs as aged so PR 103 exercises the approval label.

PR-URL: nodejs/node#65538

Assisted-by: Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva

panva commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Tested in nodejs/node-auto-test

@panva
panva marked this pull request as ready for review August 26, 2026 13:17
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 26, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 25 Aug 2026 10:43:36 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65538#pullrequestreview-5018832373
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65538#pullrequestreview-5045656685
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65538
✔  Done loading data for nodejs/node/pull/65538
----------------------------------- PR info ------------------------------------
Title      tools: label PRs lacking second approval (#65538)
Author     Filip Skokan <panva.ip@gmail.com> (@panva)
Branch     panva:commit-queue-approval-label -> nodejs:main
Labels     meta, tools, author ready, commit-queue
Commits    1
 - tools: label PRs lacking second approval
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 25 Aug 2026 10:43:36 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65538#pullrequestreview-5018832373
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65538#pullrequestreview-5045656685
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@panva panva removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Aug 27, 2026
@panva panva added the blocked PRs that are blocked by other issues or PRs. label Aug 27, 2026
@panva

panva commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Let me drill into that CQ failure before landing this. Leaving it open will help to reproduce.

@panva panva removed the blocked PRs that are blocked by other issues or PRs. label Aug 27, 2026
panva added a commit that referenced this pull request Aug 27, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@panva

panva commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Landed in 7276858

@panva panva closed this Aug 27, 2026
@panva
panva deleted the commit-queue-approval-label branch August 27, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants